search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
38 stars 23 forks source link

CMP-3009: Update manifest to include new aggregator permissions #485

Closed rhmdnd closed 11 months ago

rhmdnd commented 11 months ago

A recent change improved how the aggregator pod handled compliance check results, by allowing it to find all existing results, and prune results that were stale. This makes the state of the Compliance Check Results consistent with the latest run:

https://github.com/ComplianceAsCode/compliance-operator/pull/221

To do this though, we needed to give the aggregator pod permissions to list and delete Compliance Check Results. But, in that patch we forgot to update the bundle build to include those new permissions. This means bundle installs are currently broken for all scans because the aggregator pod gets stuck in a crashloop, due to failing permissions.

This commit updates the manifest for the bundles so that bundle installs work again.

openshift-ci-robot commented 11 months ago

@rhmdnd: No Jira issue with key CMP-3009 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to [this](https://github.com/ComplianceAsCode/compliance-operator/pull/485): >A recent change improved how the aggregator pod handled compliance check >results, by allowing it to find all existing results, and prune results >that were stale. This makes the state of the Compliance Check Results >consistent with the latest run: > > https://github.com/ComplianceAsCode/compliance-operator/pull/221 > >To do this though, we needed to give the aggregator pod permissions to >list and delete Compliance Check Results. But, in that patch we forgot >to update the bundle build to include those new permissions. This means >bundle installs are currently broken for all scans because the >aggregator pod gets stuck in a crashloop, due to failing permissions. > >This commit updates the manifest for the bundles so that bundle installs >work again. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment