search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
38 stars 23 forks source link

Fix e2e for TestManualRulesTailoredProfile #495

Closed Vincent056 closed 7 months ago

Vincent056 commented 7 months ago

We were using DisableOutdatedReferenceValidation as a label instead of an annotation, this commit fixes it.

Errors:

=== NAME  TestManualRulesTailoredProfile
    main_test.go:2765: compliancesuites.compliance.openshift.io "manual-rules-test-node" not found
--- FAIL: TestManualRulesTailoredProfile (1835.67s)
FAIL
rhmdnd commented 7 months ago

We were using DisableOutdatedReferenceValidation as a label instead of an annotation, this commit fixes it.

Errors:

=== NAME  TestManualRulesTailoredProfile
    main_test.go:2765: compliancesuites.compliance.openshift.io "manual-rules-test-node" not found
--- FAIL: TestManualRulesTailoredProfile (1835.67s)
FAIL

Interesting - when did this start failing?

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Vincent056 commented 7 months ago

Looks reasonable, but curious why this started failing.

not sure why it is started to fail just recently.