search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

Adding a new field in ScanSetting to disable remediation #498

Closed Vincent056 closed 4 months ago

Vincent056 commented 5 months ago

In order to prevent remediation gets applied unexpected, we are adding a new field to the ScanSetting, so user can set disableRemediations to true so Compliance Operator will not apply any remediation.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@Vincent056: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 9c3d01b9f8492fdb75eb9964432b1ab8a2b6492b link true /test unit
ci/prow/images 9c3d01b9f8492fdb75eb9964432b1ab8a2b6492b link true /test images
ci/prow/e2e-aws-parallel 9c3d01b9f8492fdb75eb9964432b1ab8a2b6492b link true /test e2e-aws-parallel
ci/prow/e2e-aws-serial 9c3d01b9f8492fdb75eb9964432b1ab8a2b6492b link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Vincent056 commented 4 months ago

Close this, this is not needed anymore as we are already cleaning up CCR or CR with every rescan