search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

[WIP] Add timestamp annotation #512

Closed SimonBaeumer closed 1 week ago

SimonBaeumer commented 3 months ago

Add timestamp annotation to CheckResult objects. The goal is to be able to identify when a ComplianceScan is done and has successful update all CheckResults. Additionally, from a client perspective I want to be able to identify when I received all updated CheckResults. Prior to this change it was not possible to know when a check was done if the result didn't changed.

Specification:

openshift-ci[bot] commented 3 months ago

Hi @SimonBaeumer. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimonBaeumer Once this PR has been reviewed and has the lgtm label, please assign xiaojiey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment