Closed rhmdnd closed 3 months ago
@rhmdnd: This pull request references CMP-2524 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
This still has a rough edge with the kustomization work and detecting platform deployments. Need to find an orthogonal way to handle spinning up tests on platforms.
The ROSA test worked... but still need to do some cleanup
2024/05/15 03:34:08 ProfileBundle ready (VALID)
2024/05/15 03:34:13 ProfileBundle ready (VALID)
bypassing MachineConfigPool test setup because it's not supported on rosa
bypassing MachineConfigPool test setup because it's not supported on rosa
=== RUN TestInstallOnlyParsesNodeProfiles
=== PAUSE TestInstallOnlyParsesNodeProfiles
=== CONT TestInstallOnlyParsesNodeProfiles
--- PASS: TestInstallOnlyParsesNodeProfiles (0.04s)
PASS
2024/05/15 03:34:18 cleaning up Profile Bundles
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhmdnd, Vincent056
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Implement support for only loading node profiles on managed offerings since the control plane isn't accessible. This reduces the amount of confusion for users by only presenting profiles that can be run on the platform.