search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

CMP-2524: Only load node profiles for managed OpenShift #518

Closed rhmdnd closed 3 months ago

rhmdnd commented 3 months ago

Implement support for only loading node profiles on managed offerings since the control plane isn't accessible. This reduces the amount of confusion for users by only presenting profiles that can be run on the platform.

openshift-ci-robot commented 3 months ago

@rhmdnd: This pull request references CMP-2524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/ComplianceAsCode/compliance-operator/pull/518): >Implement support for only loading node profiles on managed offerings >since the control plane isn't accessible. This reduces the amount of >confusion for users by only presenting profiles that can be run on the >platform. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=ComplianceAsCode%2Fcompliance-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhmdnd commented 3 months ago

This still has a rough edge with the kustomization work and detecting platform deployments. Need to find an orthogonal way to handle spinning up tests on platforms.

rhmdnd commented 3 months ago

The ROSA test worked... but still need to do some cleanup

2024/05/15 03:34:08 ProfileBundle ready (VALID)
2024/05/15 03:34:13 ProfileBundle ready (VALID)
bypassing MachineConfigPool test setup because it's not supported on rosa
bypassing MachineConfigPool test setup because it's not supported on rosa
=== RUN   TestInstallOnlyParsesNodeProfiles
=== PAUSE TestInstallOnlyParsesNodeProfiles
=== CONT  TestInstallOnlyParsesNodeProfiles
--- PASS: TestInstallOnlyParsesNodeProfiles (0.04s)
PASS
2024/05/15 03:34:18 cleaning up Profile Bundles
Vincent056 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment