search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

CMP-2526: Disable automatic remediation for ROSA HCP environments #520

Closed Vincent056 closed 3 months ago

Vincent056 commented 3 months ago

Since the Compliance Operator is only going to support running on HCP environments, where end users don't have access to the master nodes (or control plane), it doesn't make sense to give them a scan setting with auto remediation functionality applied.

For this case, the Compliance Operator should detect if it is running on ROSA HCP and adjust, or just not create the default-auto-apply scan settings.

openshift-ci-robot commented 3 months ago

@Vincent056: This pull request references CMP-2526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/ComplianceAsCode/compliance-operator/pull/520): >Since the Compliance Operator is only going to support running on HCP environments, where end users don't have access to the master nodes (or control plane), it doesn't make sense to give them a scan setting with auto remediation functionality applied. > >For this case, the Compliance Operator should detect if it is running on ROSA HCP and adjust, or just not create the `default-auto-apply` scan settings. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=ComplianceAsCode%2Fcompliance-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment