Fix panic due to logging issue

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks

Apache License 2.0

36 stars 22 forks source link

Fix panic due to logging issue #521

Closed rhmdnd closed 3 months ago

rhmdnd commented 3 months ago

We're seeing a panic in the log when parsing profiles on managed offerings:

"msg":"odd number of arguments passed as key-value pairs for logging","ignored key"

This is likely related to https://github.com/ComplianceAsCode/compliance-operator/pull/518

This commit updates the log to use a key-value pair so that the panic goes away.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

rhmdnd commented 3 months ago

/test e2e-aws-parallel

rhmdnd commented 3 months ago

Serial test failed with what might be a new/changed rule:

 2024/05/22 16:46:29 waiting until suite test-update-remediation reaches target status 'DONE'. Current status: AGGREGATING
2024/05/22 16:46:34 waiting until suite test-update-remediation reaches target status 'DONE'. Current status: AGGREGATING
    main_test.go:1197: expecting COMPLIANT got NON-COMPLIANT
--- FAIL: TestUpdateRemediation (121.12s)

Parallel test failure appears to have resolved itself.

rhmdnd commented 3 months ago

/test e2e-aws-serial

rhmdnd commented 3 months ago

/test e2e-aws-serial