search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

CMP-1096: Add must-gather image to relatedImages #540

Closed rhmdnd closed 1 month ago

rhmdnd commented 1 month ago

Even though the must-gather plugin image isn't necessary for running the operator, is helps users collect information when reporting issues.

By including the image reference in the relatedImages of the CSV, it's more discoverable and users can query it out of the CSV directly, instead of having to hunt through documentation and container registries.

openshift-ci-robot commented 1 month ago

@rhmdnd: This pull request references CMP-1096 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/ComplianceAsCode/compliance-operator/pull/540): >Even though the must-gather plugin image isn't necessary for running the >operator, is helps users collect information when reporting issues. > >By including the image reference in the `relatedImages` of the CSV, it's >more discoverable and users can query it out of the CSV directly, >instead of having to hunt through documentation and container >registries. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=ComplianceAsCode%2Fcompliance-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhmdnd commented 1 month ago

One thing to note for testing is that this new image should be in the new bundle images available through catalog-deploy.

github-actions[bot] commented 1 month ago

:robot: To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:540