search

ComplianceAsCode / compliance-operator

Operator providing Kubernetes cluster compliance checks
Apache License 2.0
36 stars 22 forks source link

:broom: remove downstream-specific Dockerfile #545

Closed rhmdnd closed 3 weeks ago

rhmdnd commented 1 month ago

We maintain three different Dockerfiles for similar purposes. One for CI called Dockerfile.ci, another for downstream builds called Dockerfile.ocp, and another in build/Dockerfile.

The downstream Dockerfile isn't used anywhere, so let's remove it so we have less places to update golang versions.

rhmdnd commented 1 month ago

Hold until we get good testing signal.

github-actions[bot] commented 1 month ago

:robot: To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:545
Vincent056 commented 1 month ago

/retest

Vincent056 commented 1 month ago

rosa failures looks unrelated

/lgtm

rhmdnd commented 1 month ago

/test e2e-rosa

failed to provision the rosa cluster - unrelated to this change.

rhmdnd commented 1 month ago

/test e2e-rosa

Another unrelated failure due to the rosa cluster failing to install.

rhmdnd commented 1 month ago

Fixed up the remove conflict. @Vincent056 @yuumasato should be ready for another look.

github-actions[bot] commented 1 month ago

:robot: To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:545
rhmdnd commented 1 month ago

/test images

Image registry threw a 500...

rhmdnd commented 1 month ago

Applying px, doc, and qe labels since this isn't used anywhere in our upstream build process and shouldn't require any documentation changes.

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuumasato commented 4 weeks ago

/retest-required

rhmdnd commented 4 weeks ago

Tests here are going to fail until we get https://github.com/ComplianceAsCode/compliance-operator/pull/523 landed.

github-actions[bot] commented 3 weeks ago

:robot: To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:545