Add Makefile target for pushing must-gather image

[rhmdnd]

The must-gather target had a reference to a non-existent target called must-gather-push, which resulted in the following error when you attempted to build the must-gather image locally:

make: *** No rule to make target 'must-gather-push', needed by 'must-gather'. Stop.

This commit adds in the missing Makefile target to push the image to a specific image registry so that you can build must-gather images locally and push them to your own registry (e.g., useful for testing).

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ComplianceAsCode/compliance-operator/blob/master/OWNERS)~~ [rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[github-actions[bot]]

:robot: To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:546

[BhargaviGudi]

/hold for test

[BhargaviGudi]

Verification passed with 4.17.0-0.nightly-2024-07-07-131215 + #546

podman build -t quay.io/bgudi/must-gather-ocp:pr-543-3 -f images/must-gather/Dockerfile .
STEP 1/4: FROM quay.io/openshift/origin-must-gather:latest
Trying to pull quay.io/openshift/origin-must-gather:latest...
Getting image source signatures
Copying blob 69535de51c02 done   | 
Copying blob 28d6057e65ce done   | 
Copying blob 47318e52445e done   | 
Copying blob 97da74cc6d8f done   | 
Copying blob 39168a15419f done   | 
Copying blob d8190195889e done   | 
Copying blob ca09db8018f6 done   | 
Copying config 9be99b5355 done   | 
Writing manifest to image destination
STEP 2/4: RUN mv /usr/bin/gather /usr/bin/gather_original
--> 5294cb4a3832
STEP 3/4: COPY utils/must-gather/* /usr/bin/
--> 663eed2d5891
STEP 4/4: ENTRYPOINT /usr/bin/gather
COMMIT quay.io/bgudi/must-gather-ocp:pr-543-3
--> 4faa721b81c3
Successfully tagged quay.io/bgudi/must-gather-ocp:pr-543-3
4faa721b81c307896fb1b9a43ec704cc25f32d8b2db271da13729632f7d57a0f
podman push quay.io/bgudi/must-gather-ocp:pr-543-3
Getting image source signatures
Copying blob 39168a15419f skipped: already exists  
Copying blob 47318e52445e skipped: already exists  
Copying blob 69535de51c02 skipped: already exists  
Copying blob d8190195889e skipped: already exists  
Copying blob 7fa6c8e19cf7 done   | 
Copying blob 09c74ccd0df1 done   | 
Copying blob 28d6057e65ce skipped: already exists  
Copying blob 97da74cc6d8f skipped: already exists  
Copying blob ca09db8018f6 skipped: already exists  
Copying config 4faa721b81 done   | 
Writing manifest to image destination

[BhargaviGudi]

/unhold

[BhargaviGudi]

/label qe-approved

[rhmdnd]

ROSA e2e tests are failing on quota issues with AWS. Working on resolving them, but their unrelated to this patch.

[rhmdnd]

/test e2e-rosa

[rhmdnd]

/test e2e-rosa

[rhmdnd]

/test e2e-rosa

[rhmdnd]

/test e2e-rosa

[rhmdnd]

Unable to recreate this locally on a ROSA cluster... Retesting to get better logs.

[rhmdnd]

Closes #159

[Vincent056]

/lgtm

[rhmdnd]

/test e2e-rosa

Failed on image streams, which seems unrelated.

[rhmdnd]

/test e2e-rosa

Ugh - another deployment timeout failure... Opening a bug so we can track this separately and find a way to deal with it.

[Vincent056]

Available cluster versions:
4.16.2
4.16.1
4.16.0
4.15.21
4.15.20
4.15.19
4.15.18
4.15.17
4.15.16
4.15.15
4.14.33
4.14.32
4.14.31
4.14.30
4.14.29
4.14.28
Requested cluster version not available!

not related error

[rhmdnd]

Proposed a PR that attempts to update the ROSA CI version.

https://github.com/openshift/release/pull/54704

[rhmdnd]

/test e2e-rosa