Explicitly state FindOpenSCAP cmake so it loads before it's used.

ComplianceAsCode / content

Security automation content in SCAP, Bash, Ansible, and other formats

Other

2.22k stars 698 forks source link

Closed ggbecker closed 3 weeks ago

ggbecker commented 4 weeks ago

Sometimes it could happen that the OSCAP_VERSION was being used without being defined first. This makes sure that whenever the variables are attempted to be used, they are defined.

Fix a problem where cmake would define --schematron option even if the OSCAP would be greater or equal than 1.3.5.

Since this seems to be a "race condition" type of problem, it's not that trivial to reproduce it. We'll be seeing this getting fixed in some productization runs.

github-actions[bot] commented 4 weeks ago

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

codeclimate[bot] commented 4 weeks ago

Code Climate has analyzed commit f2b97557 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

ggbecker commented 4 weeks ago

It seems to have fixed the issue, for example:

      Start 40: validate-ssg-rhel10-ds.xml
40/42 Test #40: validate-ssg-rhel10-ds.xml .........................   Passed    0.34 sec