ComplianceAsCode / content

Security automation content in SCAP, Bash, Ansible, and other formats
https://complianceascode.readthedocs.io/en/latest/
Other
2.22k stars 698 forks source link

Update networkmanager_dns_mode for bootable containers #12574

Closed matusmarhefka closed 2 weeks ago

matusmarhefka commented 2 weeks ago

Remediation of the rule networkmanager_dns_mode calls systemctl reload which doesn't work in the bootable container build environment and so we use the bash_not_bootc_build macro to not run it there.

github-actions[bot] commented 2 weeks ago

Start a new ephemeral environment with changes proposed in this pull request:

ol9 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] commented 2 weeks ago

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff ```diff bash remediation for rule 'xccdf_org.ssgproject.content_rule_networkmanager_dns_mode' differs. --- xccdf_org.ssgproject.content_rule_networkmanager_dns_mode +++ xccdf_org.ssgproject.content_rule_networkmanager_dns_mode @@ -20,7 +20,9 @@ fi fi -systemctl reload NetworkManager +if [[ "$OSCAP_BOOTC_BUILD" != "YES" ]] ; then + systemctl reload NetworkManager +fi else >&2 echo 'Remediation is not applicable, nothing was done' ```
codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit e079930f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Mab879 commented 2 weeks ago

Automatus tests pass locally, waving.