ComplianceAsCode / content

Security automation content in SCAP, Bash, Ansible, and other formats
https://complianceascode.readthedocs.io/en/latest/
Other
2.22k stars 698 forks source link

Make Automatus Sanity Pass #12590

Closed Mab879 closed 1 week ago

Mab879 commented 2 weeks ago

Description:

Make Automatus Sanity pass by adjusting how symlinks work in the failing test.

Rationale:

Make CI green.

github-actions[bot] commented 2 weeks ago

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit dc648962 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

vojtapolasek commented 1 week ago

Thank you for the fix. I understand this fixes the thing from the point of the test scenario, but shouldn't the OVAL handle symlink situation? I mean, I am fine with merging this, but do you think it is worth creating an issue against the template?

Mab879 commented 1 week ago

Thank you for the fix. I understand this fixes the thing from the point of the test scenario, but shouldn't the OVAL handle symlink situation? I mean, I am fine with merging this, but do you think it is worth creating an issue against the template?

The OVAL check just skips symlinks so that is why I changed to change the symlink to an actual file. We can create an issue on this template, but it will involve a lot of thinking about what we want this template to do.

Mab879 commented 1 week ago

With the recent release of F41, that F39 check might never finish.

Should be fine to merge without it.

vojtapolasek commented 1 week ago

OK. I will create an issue for the template. Othervise LGTM, thank you.

vojtapolasek commented 1 week ago

fyi: https://github.com/ComplianceAsCode/content/issues/12601