ComplianceAsCode / content

Security automation content in SCAP, Bash, Ansible, and other formats
https://complianceascode.readthedocs.io/en/latest/
Other
2.22k stars 698 forks source link

Adjust rule assertions 11.11 #12596

Closed yuumasato closed 1 week ago

yuumasato commented 1 week ago

Description:

Rationale:

Review Hints:

github-actions[bot] commented 1 week ago

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

rhmdnd commented 1 week ago

/test

openshift-ci[bot] commented 1 week ago

@rhmdnd: The /test command needs one or more targets. The following commands are available to trigger required jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/ComplianceAsCode/content/pull/12596#issuecomment-2468076640): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rhmdnd commented 1 week ago

/test 4.16-e2e-aws-rhcos4-high /test 4.16-e2e-aws-rhcos4-moderate /test 4.16-e2e-aws-rhcos4-stig /test 4.17-e2e-aws-rhcos4-high /test 4.17-e2e-aws-rhcos4-moderate /test 4.17-e2e-aws-rhcos4-stig /test 4.17-e2e-aws-ocp4-moderate

yuumasato commented 1 week ago

Looks good, did the partition rules get adjusted recently to make them not applicable?

Yes, forgot to link: https://github.com/ComplianceAsCode/content/pull/12562/files#diff-b1bbfcc1d8a9716415cf3a4fcc17a44ebb8a2c098f2b7a40182cf92f8d58d875

yuumasato commented 1 week ago

/test 4.16-e2e-aws-rhcos4-high /test 4.16-e2e-aws-rhcos4-moderate /test 4.16-e2e-aws-rhcos4-stig /test 4.17-e2e-aws-rhcos4-high /test 4.17-e2e-aws-rhcos4-moderate /test 4.17-e2e-aws-rhcos4-stig /test 4.17-e2e-aws-ocp4-moderate

codeclimate[bot] commented 1 week ago

Code Climate has analyzed commit 15bcad97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.