ComposableFi / composable-cosmos

The home of IBC
29 stars 95 forks source link

version 7 tracking issue #358

Open hoank101 opened 10 months ago

hoank101 commented 10 months ago

Across:

There've been some changes to make how we interact with governance more conventional, and the ability to refund unforwardable forwards has been added.

Given that PFM in particular has made fairly big changes, and it doesn't make sense to stay on retracted code, v7 will stay on v0.47.x while using the mainine wasm client and hopefully mainline IBC.

Version 7


nice to haves

faddat commented 10 months ago

hey :D

@hoank101 -- we are going to head straight to v0.50.x unless you think that this task is something that must be done this second. (and personally I am unsure)

Note: it's kinda worse than deprecated, wasmd v0.43 and v0.44 are retracted 😬

My vibe on the solution was to jump to v0.50.x but interested in your thoughts here

Related to this, I am currently working on:

https://github.com/cosmos/ibc-apps/pull/153

please feel free to push to my branch if you can help!

I am modeling it after the ibc-go simapp.

hoank101 commented 10 months ago

yeah @faddat, I think we need step by step, i just have PR at https://github.com/ComposableFi/composable-cosmos/pull/361

i will check ibc-apps

faddat commented 10 months ago

@hoank101 will review now :D

it may make sense to do an ugprade on v0.47.x before v0.50.x I'll put you in our channel with skip, I am talking with Barry about that now

faddat commented 10 months ago

@hoank101 Actually I think you found a set of important issues. It took me crazy long to finish this up, but thank you!

I'm going to make this issue into a v7 tracker.

@RustNinja this means that your current work may even make it into the upcoming release!

dzmitry-lahoda commented 10 months ago

Hello, how it is going? May I check WASMD migration if that is good to check ? I guess it would be that I check their release notes and see nothing will break. Said that, do we really have any contracts except mine (CVM+MANTIS)? I doubt.

dzmitry-lahoda commented 10 months ago

I am for jumping to latest possible WASMD which is compile compatible to our go packages - I think all contracts on our chain are alfa - so doubt we care. Will recheck.

Other note - need to bump ontract size 2x like Neutron/Osmosis did and make FEE for contract (now it is zero), may be at least 20 USD to prevent SPAM.

faddat commented 10 months ago

@dzmitry-lahoda this upgrade shouldn't break contracts, except for grandpa.

Grandpa, we will need to update. We should study the smooth way of doing that.

faddat commented 10 months ago

@dzmitry-lahoda we do not yet have a migration, this is only the initial set of changes.

idk if you have a preference: typically, I'll get the changes in place, look at the global changeset, and then write the migration.

There's rather a lot to be concerned with here, so please do feel free to jump in.

I am thinking to merge

to the release/v7.0.x branch tonight.

We also need to ensure that this repository can publish packages (in this case docker images) to ghcr.io so we can put interchaintest back in the ci flow

dzmitry-lahoda commented 10 months ago

I am thinking on making changes to wasmd, assuming nobody works on wasmd now.

What is timeline on delivering this branch? Assuming I do 100% of wasmd related work

dzmitry-lahoda commented 10 months ago

https://github.com/ComposableFi/composable-cosmos/tree/faddat/upgrade-to-mainline

I testind wasmd on this branch and adding config points by me.

https://github.com/ComposableFi/composable-cosmos/issues/281

https://github.com/ComposableFi/composable-cosmos/issues/385

JafarAz commented 10 months ago

@faddat @hoank101 Hey sirs, what is the timeline for getting version 7 feature complete?

dzmitry-lahoda commented 10 months ago

some wasmd setup https://github.com/ComposableFi/composable-cosmos/pull/394 , made it some address only and better size. added v7 upgrade handler.

if somebody knows how to set Upload contract fee - would be awesome. not found how.

dzmitry-lahoda commented 10 months ago

working on pfm upgrade