search

ComposableFi / composable-cosmos

The home of IBC
29 stars 95 forks source link

use max valdiator always 100 #428

Closed RustNinja closed 6 months ago

faddat commented 7 months ago

I do not like this, but I do think that this is the right approach. If the currently running chain is using v6.3.x, then this is what it should be applied to.

joe-bowman commented 7 months ago

lgtm

faddat commented 7 months ago

@joe-bowman does it start from v6.3.6?

That's all I really want to review for.

joe-bowman commented 7 months ago

Ah, didn't realise the chain was on 6.3.6 right now

Edit: it is not - there was an upgrade to 6.4.x today.

blasrodri commented 7 months ago

@joe-bowman + @faddat sdk team suggests https://github.com/cosmos/cosmos-sdk/pull/19226/files

faddat commented 7 months ago

Hey that looks like an actual fix, I tend to agree with them.

joe-bowman commented 7 months ago

Agreed; looks like a proper fix rather than a quick ‘let’s get the chain back up’ hotfix.

On Wed, 24 Jan 2024 at 17:57, Jacob Gadikian @.***> wrote:

Hey that looks like an actual fix, I tend to agree with them.

— Reply to this email directly, view it on GitHub https://github.com/ComposableFi/composable-cosmos/pull/428#issuecomment-1908648024, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA7QYDJ3U4DYT6ZZKOLM23YQFDPBAVCNFSM6AAAAABCJERSUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGY2DQMBSGQ . You are receiving this because you were mentioned.Message ID: @.***>