ComposableFi / composable-ibc

A trustless, cross-chain bridging protocol.
https://picasso.network
76 stars 50 forks source link

Weaken GRANDPA proof validation #497

Closed vmarkushin closed 3 months ago

vmarkushin commented 3 months ago

verify_with_voter_set function is performing additional validation that go beyond the standard implementation (section 2.3), possibly leading to proofs not being accepted while valid.

Instead, we need to accept all finality justifications where is_valid is true. The equivocations or other misbehaviors detected in the justifications must be handled too but not should not reject the proof.

kirillt commented 3 months ago

Related discussion for reference: https://substrate.stackexchange.com/questions/8701/grandpa-finality-proofs-validation-and-equivocations