This PR tries to cleanup the code so that we have more idiomatic go files and related tests.
Bellow you will find the more complete explanation for each one of the sections.
Update beefy.proto
Remove not used libs
Add comment to BeefyMmrLeaf to fix make proto cmd issue
Idiomatic Golang related
Update method receivers var name on so that they are all the same for all methods. Files changed: beefy.pb.go
Update test cases to make use of require.NoError, require.Equal, require.NotEmpty,
Update fmt.Printf to t.Logf or related compatible log func for tests.
Remove not require castings
Update error messages to not start with capital letter
Update other method signatures such as fetchParaIds to fetchParaIDs to follow go convention for Initialisms
Fixed typos
absense -> absence
Update go.mod
Gossamer to latest
closes: #7
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Description
This PR tries to cleanup the code so that we have more idiomatic go files and related tests. Bellow you will find the more complete explanation for each one of the sections.
Update beefy.proto
Idiomatic Golang related
beefy.pb.go
require.NoError
,require.Equal
,require.NotEmpty
,fmt.Printf
tot.Logf
or related compatible log func for tests.fetchParaIds
tofetchParaIDs
to follow go convention forInitialisms
Fixed typos
absense
->absence
Update go.mod
closes: #7
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes