CompositionalDietaryNutritionOntology / cdno

Compositional Dietary Nutrition Ontology
Creative Commons Zero v1.0 Universal
11 stars 3 forks source link

Suggestion to import vitamin (role) from ChEBI #125

Open NutrientInstitute opened 5 months ago

NutrientInstitute commented 5 months ago

Currently, the term vitamin (molecular entity) (CDNO:0000014) has the definition "An organic molecule that has a vitamin(role)." As such, it would be appropriate to import the term vitamin (role) (CHEBI:33229).

It may also be viable to import the parent terms of vitamin(role): biochemical role (CHEBI:52206) and biological role (CHEBI:24432).

Links to terms in OLS:

NutrientInstitute commented 1 month ago

CDNO term 'vitamin (molecular entity)' (CDNO:0000014) and the ChEBI term 'vitamin (role)' (CHEBI:33229) could be linked using the property 'has role' (RO:0000087)

LilyAndres commented 1 month ago

So I have added the changes described above but having a look at the issue #65 we had to create the following hierarchy:

dietary role [CDNO:0500002]
          human dietary role [CDNO:0500001]
                   vitamin role [CHEBI:33229]

This is the hierarchy I have at the moment:

Screen Shot 2024-08-09 at 5 05 10 pm
  1. We need a definition for "dietary role"
  2. Do we want to import: biological role biochemical role

@recombics, @ddooley

recombics commented 1 month ago

Currently, the term vitamin (molecular entity) (CDNO:0000014) has the definition "An organic molecule that has a vitamin(role)." As such, it would be appropriate to import the term vitamin (role) (CHEBI:33229).

It may also be viable to import the parent terms of vitamin(role): biochemical role (CHEBI:52206) and biological role (CHEBI:24432).

Links to terms in OLS:

@LilyAndres It seems to me that the current definition for 'human dietary role' should be that for 'dietary role' since it does not mention humans or any other taxa directly (so eg could work for food ingested by Venus FlyTrap). Suggest update the CDNO_0500001 to include reference to humans ?

recombics commented 1 month ago

@NutrientInstitute further, I think the biochemical role is quite specific to biochemical context and only overlaps with dietary role (would invoke eg nutritional attribute but not necessarily a physical attribute).
i would think a dietary role is a biological role is a role seems reasonable if required for clarity. Take into account that dietary role may extend beyond what we typically consider as 'biological', say social or other domain?

NutrientInstitute commented 1 month ago

@recombics That is a good point, dietary roles can be social, cultural, religious, etc... I agree that the clearest parent for dietary role would be biological role.

However, we should still import biochemical role into CDNO since it is the parent of vitamin (role) and the definition of vitamin (role) begins with "A biochemical role..."

@LilyAndres @recombics Vitamin (role) also has another set of parents (i.e. physiological role, food component, nutrient, and micronutrient), would it be valid to import these terms as well or do they not align with the logic used in CDNO?

please let me know what you think! image

LilyAndres commented 1 month ago

Thanks for your comments @recombics @NutrientInstitute, I did the release because I will have a lot of work next week and I didn't want to delay it. I will add the multiple roles suggested, I think we could add the other set of parents physiological role, food component, nutrient, and micronutrient.

LilyAndres commented 1 month ago

I might make a new issue. I also have to add the soluble and insoluble vitamin roles with their respective vitamers. I will do this for the next release.