Closed isaacabraham closed 1 year ago
Yes, similar to that. The WebApp builder already lets you supply a Docker container and Azure Container registry path, plus the startup command for docker - what I think wasn't available previously was the ability to set the startup command if you just uploaded your app using Zip Deploy (HTTP upload) - in that case, App Service creates a docker container for you with your app, but doesn't know what to use for the startup command so it just sits there doing nothing.
@ninjarobot Ok I've remembered how you do it on Linux Web Apps again. If you supply a web.config
file that contains the startup path, the app service uses that to do it. So this PR isn't really necessary.
@isaacabraham do you still want to merge this?
@isaacabraham I'm not sure whether you want to include this or not since you figured out another way. Do you want to merge this feature?
I don't think it's really needed any more although it doesn't hurt to merge in.
This PR closes #999
The changes in this PR are as follows:
startup_command
keyword to the Web App builder.I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:
I'll test it end-to-end shortly. I'm sure I've done Linux deployments in the past so I'm surprised I can't find a clear way of doing this - @ninjarobot do you know any way to already do this in Farmer?