CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
523 stars 157 forks source link

Bugfix to remove apiVersion from embedded routes in Route Table #1007

Closed ninjarobot closed 1 year ago

ninjarobot commented 1 year ago

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here: No documentation update since this is an internal bug fix.

routeTable {
    name "test-rt"
    add_routes [
        route {
            name "virtual-net1"
            addressPrefix "100.72.16.0/24"
            nextHopIpAddress "100.72.2.53"
        }
        route {
            name "virtual-net2"
            addressPrefix "192.168.100.0/24"
            nextHopIpAddress "100.72.2.53"
        }
    ]
}
ninjarobot commented 1 year ago

@thinkdavid can you please review this minor change so that routes can be nested within the route table? The apiVersion on the nested routes was causing this error:

Could not find member 'apiVersion' on object of type 'Route'. Path 'properties.routes[0].apiVersion'