CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
523 stars 157 forks source link

KEDA spelling for scaling #1010

Closed et1975 closed 1 year ago

et1975 commented 1 year ago

This PR closes #1009

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here:

Seems straightforward.

isaacabraham commented 1 year ago

Thanks for doing this @et1975 - really appreciate it! can you confirm that this fixes the issue or send me a link for the official specs just to show the misspelling issue?

et1975 commented 1 year ago

Ran a deployment, looks good: image

I'm not sure why this wasn't an issue earlier, but at some point my scale rules started showing up in the logs as errors and apps that used them were failing to deploy. The support ticket discussion indicated this was the issue.

isaacabraham commented 1 year ago

Thank you!

ninjarobot commented 1 year ago

Thanks for the contribution. This is released in 1.7.17 and now available on nuget.