CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
517 stars 156 forks source link

VM: External diagnostics storage does not generate dependency #1022

Closed ninjarobot closed 1 year ago

ninjarobot commented 1 year ago

This PR closes #959

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here: Bugfix, no doc change.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

vm {
    name "my-vm"
    username "azureuser"
    diagnostics_support_external (Farmer.Arm.Storage.storageAccounts.resourceId "externalvmdiag")
}
ninjarobot commented 1 year ago

@ericsoler1 this change enables the VM builder to honor the linked resource being passed as managed or unmanaged. If only an ID is passed, it will make it unmanaged. Please review.

@isaacabraham could you also please review this?