CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
526 stars 156 forks source link

external resource role assignment scope #1023

Closed et1975 closed 1 year ago

et1975 commented 1 year ago

This PR closes #1012

The original ask focused on removing the version requirement, but that is a huge and orthogonal change to the latter point that implicitly created dependency is actually a blocker.

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here: Role assignments have no docs.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

                let actual : IArmResource = 
                    { Name = ResourceName "assignment"
                      RoleDefinitionId = Roles.Contributor
                      PrincipalId = ArmExpression.create "1" |> PrincipalId
                      PrincipalType = PrincipalType.User
                      Scope = privateClouds.resourceId "mySDDC" |> UnmanagedResource 
                      Dependencies = Set.empty }
ninjarobot commented 1 year ago

Thanks for the enhancement. This is now released in 1.7.20 and available on nuget.