When making app-settings into key-vault secret names sanitize the name.

[mike-wade]

This PR closes #1035

The changes in this PR are as follows:

• When creating keyvault secrets for web app appsettings replace characters unsupported in keyvault secret names with -.

I have read the contributing guidelines and have completed the following:

• [X] Tested my code end-to-end against a live Azure subscription.
• [X] Updated the documentation in the docs folder for the affected changes.
• [X] Written unit tests against the modified code that I have made.
• [X] Updated the release notes with a new entry for this PR.
• [X] Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

open Farmer
open Farmer.Builders

let webApplication = webApp {
    name "mw-farmer-test"
    secret_setting "csection:secret"
    sku WebApp.Sku.Free
    use_keyvault
}

let template = arm {
    location Location.WestEurope
    add_resources [
        webApplication
    ]
}

template
|> Writer.quickWrite "mw-farmer-test"

If I haven't completed any of the tasks above, I include the reasons why here:

• Not sure if documentation needs updating? I think this is a bit of a bugfix?
• Will wait for PR to be accepted in principal before doing the remaining tasks.

[mike-wade]

Thanks @ninjarobot, this worked in my test to a real Azure sub.

Its worth pointing out that the secret parameter name gets updated with a key-vault friendly parameter name so csection:secret needs a param with name of csection-secret at deploy time. Is this fine?

[ninjarobot]

@mike-wade yes, that's fine, if there's a reasonable way to add that to the docs, it might help users. If not, they'll get prompted about missing parameters at least.

[ninjarobot]

@mike-wade this is merged and released and now available in Farmer 1.7.26. Thanks for the contribution!