CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
526 stars 156 forks source link

Function builder creates obsolete Functions 1.x "AzureWebJobsDashboard" app setting #1057

Closed antonburger closed 1 year ago

antonburger commented 1 year ago

It looks like Farmer takes the same storage account specified for AzureWebJobsStorage and automatically also uses it for the AzureWebJobsDashboard app setting:

https://github.com/CompositionalIT/farmer/blob/7d3d4e82f051aec6ac14c8bd41edd23e794913c7/src/Farmer/Builders/Builders.Functions.fs#L215-L216

When I deploy a function app from a Farmer app that generates this setting, I get the following logs in Application Insights when functions are executed:

The Dashboard setting is no longer supported. See https://aka.ms/functions-dashboard for details.

and the guidance at that URL says:

AzureWebJobsDashboard

Optional storage account connection string for storing logs and displaying them in the Monitor tab in the portal. This setting is only valid for apps that target version 1.x of the Azure Functions runtime.

as well as:

For better performance and experience, runtime version 2.x and later versions use APPINSIGHTS_INSTRUMENTATIONKEY and App Insights for monitoring instead of AzureWebJobsDashboard.

It seems it would be better to either:

I'd be happy to submit a PR for either solution.