CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
517 stars 156 forks source link

Implementing Virtual Kubelet Extensions Support in Container Group #1064

Closed ahmed-ebaid closed 10 months ago

ahmed-ebaid commented 10 months ago

This PR closes #1063

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

ninjarobot commented 10 months ago

@ahmed-ebaid do the changes mentioned above make sense? I just want to avoid any breaking changes in the builders, so it's the most important that those follow conventions from the start. The rest of the PR looks good, so can merge once that's adjusted.

Thanks again for the contribution!

ahmed-ebaid commented 10 months ago

@ahmed-ebaid do the changes mentioned above make sense? I just want to avoid any breaking changes in the builders, so it's the most important that those follow conventions from the start. The rest of the PR looks good, so can merge once that's adjusted.

Thanks again for the contribution!

No issues on suggested changes - these were addressed in the new PR - thank you for your review

ninjarobot commented 10 months ago

Thanks @ahmed-ebaid

ninjarobot commented 10 months ago

@martinbryant and/or @isaacabraham would you please be able to cut the 1.7.28 release as I'm out of pocket for the next couple of days.