CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
514 stars 156 forks source link

Storage-accounts: Add restrict_to_ips taking a list of IPs #1096

Closed Thorium closed 4 months ago

Thorium commented 4 months ago

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here:

Thorium commented 4 months ago

If I try to run Fantomas, it gives me like 200 files changed, maybe there has been some recent update with line-ending changes or something?

ninjarobot commented 4 months ago

Are you using your global fantomas, by chance? It is likely a different version. We need to upgrade the version used with Farmer.

Can you use the local one that you get from dotnet tool restore and see if that does better?

Otherwise, it may be git settings with the line endings.

Thorium commented 4 months ago

Thanks, the fix was to force git line endings to Unix, as Fantomas seems to use Unix endings.

ninjarobot commented 4 months ago

Thanks again @Thorium, this is in the 1.8.8 release, now available on nuget.