CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
514 stars 156 forks source link

Add option to set DAPR protocol for Container Apps #1100

Open fatim opened 3 months ago

fatim commented 3 months ago

This PR closes #1083

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here:

I don't have experience using container apps with Dapr in Azure. This change produces correct ARM config, I've used this doc as a reference - https://learn.microsoft.com/en-us/azure/container-apps/enable-dapr?tabs=arm1 Could somebody test this in Azure.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let httpContainerApp =
    containerApp {
        ...
        // Dapr config
        dapr_app_id "http"
        dapr_app_port 5000us

        // new parameter added by this PR
        dapr_app_protocol "grpc"
        ...
    }
jwthomson commented 2 months ago

Thanks for this contribution!

This looks great in principle. @isaacabraham is going to have a look at it, apologies for the delay.