Turn on Dapr in Container Apps

CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!

https://compositionalit.github.io/farmer

MIT License

524 stars 157 forks source link

Turn on Dapr in Container Apps #930

Closed isaacabraham closed 2 years ago

isaacabraham commented 2 years ago

The changes in this PR are as follows:

Actually turn on Dapr when you supply the Dapr ID for the container app.
Slight cleanup on formatting of Container Apps ARM file.
App Insights integration for container apps + DAPR.

There are no changes to the API - this is an internal change only.

I have read the contributing guidelines and have completed the following:

[x] Tested my code end-to-end against a live Azure subscription.
[x] Written unit tests against the modified code that I have made.
[x] Updated the release notes with a new entry for this PR.

isaacabraham commented 2 years ago

@ninjarobot FYI - I'm trying to add the daprcomponents resource (which lives underneath Container Apps) which will also allow adding e.g. a storage account as the state store. It might not make the cut for the next release though, so feel free to either accept this one and I'll do another PR for the rest, or maybe easier just to hold releasing this.

isaacabraham commented 2 years ago

Move to draft temporarily.

ninjarobot commented 2 years ago

Move to draft temporarily.

I moved it out of 1.7.2 since it's a WIP.

isaacabraham commented 2 years ago

I'm going to re-create this PR based on master (formatting changes have gone too far) and only include the core bits that I know work. The component stuff can go in another time.