CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
527 stars 159 forks source link

Fantomas second #958

Closed isaacabraham closed 2 years ago

isaacabraham commented 2 years ago

This PR closes #

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

I still need to do the above (standards etc.).

isaacabraham commented 2 years ago

@ninjarobot yep, that's what I thought too - hence my comment above for that. Let me do that and we can get this merged in - you'll need to apply it to that active PR to get things through I suspect.

ninjarobot commented 2 years ago

@ninjarobot yep, that's what I thought too - hence my comment above for that. Let me do that and we can get this merged in - you'll need to apply it to that active PR to get things through I suspect.

Want me to go ahead and merge and then that can be added later?

nojaf commented 2 years ago

@isaacabraham would it be ok if we added Farmer to our homepage once this gets merged?

ninjarobot commented 2 years ago

@isaacabraham can this be merged and any improvements happen in a later PR? It's got a lot of changes so will create a lot of conflicts if left open as people open more PRs (either their PRs or yours).

isaacabraham commented 2 years ago

@nojaf yep, absolutely.

isaacabraham commented 2 years ago

@ninjarobot yep - I was just going to add the docs / guidance but yes, totally happy to merge in right now.