CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
524 stars 157 forks source link

Keep RG and Subs components from VNet when generating a subnet resourceId #967

Closed TheRSP closed 1 year ago

TheRSP commented 2 years ago

This PR closes #

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here:

let myVnet = Arm.Network.virtualNetworks.resourceId("myvnet", groupName="other-group")
vm {
    name "myvm"
    username "azureuser"
    link_to_unmanaged_vnet myVnet
    subnet_name "default"
}
ninjarobot commented 2 years ago

Looks good, thanks again @TheRSP. Please resolve the merge conflict and I'll merge the PR.

ninjarobot commented 1 year ago

@TheRSP can you please resolve merge conflicts so this can be merged? Thank you!

TheRSP commented 1 year ago

Sorry for the delay. Merge should be fixed now.

ninjarobot commented 1 year ago

Thanks for your contribution! This is now released in 1.7.9 and available on nuget.