CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
523 stars 157 forks source link

Possibility of modifying NSG SecurityRule priorities, fix for #990 #991

Closed Thorium closed 1 year ago

Thorium commented 1 year ago

This PR closes #990

The changes in this PR are as follows:

I have read the contributing guidelines and have completed the following:

If I haven't completed any of the tasks above, I include the reasons why here: I did test that the values are correct, but this was a builder-side hard-coded value parametrization only, so there is nothing to be added to the data-models or ARM templates, so no changes to deploy to Azure.

Thorium commented 1 year ago

This is a very tiny changeset. The CI failure is definitely not my fault, it fails on dotnet configs and I've not changed anything there.

ninjarobot commented 1 year ago

Thank you for the fix...that's an odd limitation I wasn't aware of. I appreciate you made this backwards compatible.

The CI failure is for the fantomas check and can be fixed by running dotnet fantomas src -r (local tool installed automatically on restore) and committing the updates in your PR.