CompositionalIT / farmer

Repeatable Azure deployments with ARM templates - made easy!
https://compositionalit.github.io/farmer
MIT License
523 stars 157 forks source link

Support for adding NSG rules to an existing NSG #992

Closed UrviGoel closed 1 year ago

UrviGoel commented 1 year ago

Currently the buildNsgRule function is defined as an internal function, not allowing user to create an NSG rule attached to existing NSG.

let internal buildNsgRule (nsgName: ResourceName) (rule: SecurityRuleConfig) (priority: int)

Can we please add support to create NSG rule with specified priority and an NSG as linked resource?

ninjarobot commented 1 year ago

@UrviGoel can you please review #1049 which allows you to add security rules to an existing NSG as well as setting their priority?

UrviGoel commented 1 year ago

@ninjarobot this looks great and solves our problem. Thanks!