search

CompositionalIT / feliz-ag-grid

9 stars 4 forks source link

Update feliz #20

Closed martinbryant closed 5 months ago

martinbryant commented 6 months ago

As this package uses v1.x of Feliz and Fable React it has conflicts when trying to use in a project that uses Feliz v2.x. This PR will update all things Feliz, React and Fable

martinbryant commented 5 months ago

All good! Perhaps it'd be worth including a changelog (CHANGELOG.md?) to record that there is a breaking change, in case package users come wondering why the latest version of the package doesn't work for them?

I'm okay with that going into a separate PR (or even into an issue that you don't raise a PR for) if you're keen to get this out soon to unblock you.

Completely agree and so I think we should go with a v1 release as it is a breaking change.

I have gone with a version compatibility chart on the readme and would be great to get your thoughts

martinbryant commented 5 months ago

16