search

CompositionalIT / feliz-ag-grid

9 stars 4 forks source link

No longer need to tag the commit as per readme #21

Closed martinbryant closed 5 months ago

martinbryant commented 5 months ago

When doing the version 1 release, I did not tag the commit as per the readme so the github action uses the version identified in the AgGrdi.fsproj file to add as a tag

isaacabraham commented 5 months ago

Is the issue here to update the readme then?

mattgallagher92 commented 5 months ago

The tag isn't for automation, it's to make it easier to identify which commit corresponds to each package version, and to get GitHub to notice that there is a new release: image

I'll update the README to say that, but I think we should keep the step.

mattgallagher92 commented 5 months ago

@martinbryant see #24