CompuMasterGmbH / cammIntegrationPortal

camm Integration Portal (based on camm Web-Manager)
MIT License
2 stars 1 forks source link

Data protection cleanup: Deleted users and minimal data #31

Closed jochenwezel closed 6 years ago

jochenwezel commented 7 years ago

Data protection cleanup should keep a minimal amount of data, because some applications might refer to those user accounts: in case data protection is very aggressive and removes absolutely all user account data, an application might get a UserNotFoundException, but it must be e.g. a UserHasBeenDeletedException or empty user name/data (depending on lookup/search methods/arguments)

For this, there is the need to save some minimal data for all user accounts in log_users:

cmalbertschw commented 7 years ago

on-remove of user account: IsDeletedUser="1"

Basically already exists as "DeletedOn"

jochenwezel commented 7 years ago

Okay, so we should use "DeletedOn"! 👍

jochenwezel commented 7 years ago

Update: for compatibility reasons, we should use IsDeletedUser="1" as well as DeletedOn=...

in case DeletedOn is available and IsDeletedUser is missing, IsDeletedUser should be interpreted as "1" in case IsDeletedUser is available and DeletedOn is missing, DeletedOn should be interpreted as 1/1/1900 Caution: above double-check rule should never cause indefinite loop!

cmalbertschw commented 7 years ago

After discussion with JW, we concluded UserHasBeenDeletedException is missing an use case.

cmalbertschw commented 7 years ago

in case DeletedOn is available and IsDeletedUser is missing, IsDeletedUser should be interpreted as "1" in case IsDeletedUser is available and DeletedOn is missing, DeletedOn should be interpreted as 1/1/1900

This is probably only relevant to the applications using these flags instead of the core application, right? If so, ticket can be probably be closed.