search

Compuskills-Jerusalem / shuk-routing

Capstone project for the 2018 Mens Software Development Program at Compuskills. Provides a Waze (R) like experience for visitors to the Machane Yehuda market in Jerusalem, Israel.
0 stars 1 forks source link

Create new tables #13

Open ykahan opened 6 years ago

ykahan commented 6 years ago

We need two new tables. One for commodities-to-be-added, another for stalls-to-be-added.

ykahan commented 6 years ago

@ShmielB

I'm thinking that it would be a good idea to set up these tables so that we can identify the user that suggested a particular addition. Then we can see, over time, which users make good suggestions (and perhaps eventually "promote" them so that their suggestions are automatically incorporated into our production DB), and which ones make bad suggestions, suggestions that will continue to require checking, whether manual or automated.

Of course, that would also require us to create a Users table and make it possible for users to Sign Up and Log In to the UI. What do you think?

ykahan commented 6 years ago

Oh. Sorry about that--your screenname is very similar to that of one of my teammates. Typo on my part.

On Thu, Jul 19, 2018 at 11:01 PM, Stephen Hmiel notifications@github.com wrote:

I think you @-ed the wrong person, I have no idea what any of this is and I've never seen this repo.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Compuskills-Jerusalem/shuk-routing/issues/13#issuecomment-406396612, or mute the thread https://github.com/notifications/unsubscribe-auth/APOLLUbbRjtCm_aFgRRZPwcVCmtgQQdMks5uIOWJgaJpZM4VU_JG .

ShmielB commented 6 years ago

@ykahan right , the users table we also need to create because of the flag for each add what we discussed in #3 . and also the other two as you said . i would like to do some Database stuff if you don't mind to assign this to me thanks.

ykopstein commented 6 years ago

@ykahan @ShmielB A couple things to keep in mind when you work on this feature

  1. Do you want to maintain a link btwn the original "suggestion" and the stall that gets created? If yes, how?

  2. If you use a "points" or "reputation" system, do you want to denormalize it for speed? To what degree?

  3. How much of this information do you want the end user and/or the reviewer to know?

ShmielB commented 6 years ago

@ykosbie @ykahan I think we should first implement the first part of adding the Commodety / Sall if it dose not yet exist in the database to a the tables @ykahan suggested in the first comment in this issue , as we concluded in class on this topic .

Afterwards we could work on the second part of @ykahan second comment . and the part of who added it we anyway need to implement as discussed in #3 .

Maybe we should start braking it up into requirements .

ykopstein commented 6 years ago

@ShmielB As of now noone has taken responsibility for the extra issues discussed in this issue (besides the new tables). I'm going to open an issue and assign it to you to fix that. Remember to always do that in the future so nothing falls through the cracks!

ShmielB commented 6 years ago

@ykosbie How do i set something to Milestone ?

like what @ykahan sugessted about the eventually "promote" some users .

ShmielB commented 6 years ago

@ykahan As disscused in #22 the new tables need to be different from what we said before .

ykahan commented 6 years ago

@ShmielB @ykosbie Sorry I've been totally inactive for over a week.

I was trying to work on this issue just now, and I ran into a problem--I can't find the .sql files in the project structure. Would you mind reminding me where they go?