Computational-Morphogenomics-Group / MarkerMap

Marker selection, supervised and unsupervised
MIT License
5 stars 1 forks source link

Add Test Framework #7

Closed WilsonGregory closed 2 years ago

WilsonGregory commented 2 years ago

Changes

Tests

Doc Changes

beelze-b commented 2 years ago

I think this is great. Adding robustness and tests for the (de)serialization of data, models, results, etc is super good.

I am curious to your thoughts on what parts of the code most need tests. Some of the code needs reformatting, and adding tests to those sections might be imperative. Or they could also be unnecessary if we end up discarding that part of the code.

WilsonGregory commented 2 years ago

I think the tests will be most useful to me just to sanity check that I didn't break the existing code when doing a refactor or adding some feature to an existing function. So I just plan on writing tests as I go along for stuff I am changing. So I don't think there are critical areas in the codebase that need tests written right now.

The one place where it might be good to write a few tests is the main MarkerMap class functionality. Maybe just a few to ensure that the combination of args makes sense.