search

ComputationalCryoEM / ASPIRE-Python

Algorithms for Single Particle Reconstruction
http://spr.math.princeton.edu
GNU General Public License v3.0
45 stars 21 forks source link

sklearn API change #1120

Closed j-c-c closed 1 month ago

j-c-c commented 1 month ago

In a recent release sklearn altered the API of the PCA class methods _fit_full() and _fit_truncated(). Formerly, the namespace of the data was determined within these methods. Now, the namespace is determined in the method _fit() which calls the above methods and passes the namespace as an argument.

This API changed caused our subclass, ComplexPCA, of sklearn's PCA class to be broken.

In this PR I've made a similar change to our subclass ComplexPCA.

j-c-c commented 1 month ago

Looks like sklearn v1.5.0 only supports python 3.9-3.12. So I'll revert the changes and pin to usable version of sklearn until we're ready to move our python window.

garrettwrong commented 1 month ago

I'm going to change this to "Ready for Review" just to kick off the next round of CI jobs.