search

ComputationalCryoEM / ASPIRE-Python

Algorithms for Single Particle Reconstruction
http://spr.math.princeton.edu
GNU General Public License v3.0
45 stars 21 forks source link

do_refl option of covar2d, dead code #266

Open garrettwrong opened 3 years ago

garrettwrong commented 3 years ago

During #231, in covar2d.py _get_covar's. do_refl=False case does not appear to be tested/used by our code anywhere. If we don't plan to use it, we might want to remove it. Otherwise, we might want to test it is working correctly and stuff into a unit test.

janden commented 3 years ago

It's quite rare that we'll want to use it, but it fills an important mathematical role (requiring equivariance with respect to just SO(2) instead of all of O(2)). It would be nice to keep, but if it's too much work, we can remove it.

garrettwrong commented 3 years ago

Thanks, sounds like we should keep it then. I don't expect it is a lot of work.