search

ComputationalPhysiology / gotran

Library for declaring and translating ODEs
http://computationalphysiology.github.io/gotran/
GNU Lesser General Public License v3.0
2 stars 1 forks source link

Add retry mechanism to deal with flaky KeyError #42

Closed finsberg closed 1 year ago

finsberg commented 1 year ago

I am unable to find out what causes this key error, but the problem is occuring when differentiation the expressions. The _xi_n variables are dummy variables introduced by sympy, see e.g https://github.com/sympy/sympy/issues/13791

Retrying to initialise the component seems to work, so this is a possible fix.

Fix #24

KGHustad commented 1 year ago

I'm a bit confused. Didn't you apply this fix in https://github.com/ComputationalPhysiology/gotran/pull/40?

finsberg commented 1 year ago

I'm a bit confused. Didn't you apply this fix in #40?

Yes, we did. But it was merged into master and not main🙃

KGHustad commented 1 year ago

Ah, so are we not using master anymore?

finsberg commented 1 year ago

Nope, main should be the default branch.

finsberg commented 1 year ago

Still seems to be a problem though: https://github.com/ComputationalPhysiology/goss/actions/runs/4124734861/jobs/7124354344#step:6:868