search

ComputationalProteomicsUnit / maker

Makefile for R packages
GNU General Public License v3.0
31 stars 5 forks source link

don't rebuild vignette when checking #10

Closed lgatto closed 9 years ago

lgatto commented 9 years ago

What do you think of replacing 

ifeq (${VIG},1)
  BUILDARGS := $(filter-out --no-build-vignettes,$(BUILDARGS))
  CHECKARGS := $(filter-out --no-vignettes --no-build-vignettes,$(CHECKARGS))
endif

with 

ifeq (${VIG},1)
  BUILDARGS := $(filter-out --no-build-vignettes,$(BUILDARGS))
  CHECKARGS := $(filter-out --no-vignettes,$(CHECKARGS))
endif

I don't think we need to rebuild the vignette in the context of maker, as it will just have been build. R CMD check --no-build-vignettes is also what is used on the Bioc build servers.

sgibb commented 9 years ago

I think this change would be fine because in the current version make build PKG=xyz VIG=1 builds the vignette twice.

On 2014-07-23 22:54:09, notifications@github.com wrote:

What do you think of replacing

ifeq (${VIG},1)
  BUILDARGS := $(filter-out --no-build-vignettes,$(BUILDARGS))
  CHECKARGS := $(filter-out --no-vignettes --no-build-vignettes,$(CHECKARGS))
endif

with

ifeq (${VIG},1)
  BUILDARGS := $(filter-out --no-build-vignettes,$(BUILDARGS))
  CHECKARGS := $(filter-out --no-vignettes,$(CHECKARGS))
endif

I don't think we need to rebuild the vignette in the context of maker, as it will just have been build. R CMD check --no-build-vignettes is also what is used on the Bioc build servers.

Reply to this email directly or view it on GitHub: https://github.com/ComputationalProteomicsUnit/maker/issues/10