search

ComputationalRadiationPhysics / graybat

Graph Approach for Highly Generic Communication Schemes Based on Adaptive Topologies :satellite:
Other
8 stars 4 forks source link

Making all class members private #116

Closed theZiz closed 7 years ago

theZiz commented 7 years ago

Imho class members like "hostedVertices" of Cage should not be accessible from the outside -- especially as getters and setters already exist.

Consequently the examples using the member should be changed, too.

erikzenker commented 7 years ago

The reason for accessing them directly was pure lazyness from my side. But, you are right. I will work on that in the next days and provide a pull request. Would you like to support me in the review process ?

theZiz commented 7 years ago

Yeah, I guess this makes sense. I put it on my ToDo for tuesday ;)

erikzenker commented 7 years ago

I provided a PR for this issue (See #117).