search

ComputationalRadiationPhysics / haseongpu

HASEonGPU: High performance Amplified Spontaneous Emission on GPU
http://www.hzdr.de/crp
Other
7 stars 6 forks source link

removed typename from calc_phi_ase_graybat.cc #98

Closed slizzered closed 9 years ago

slizzered commented 9 years ago

typename is not required here by gcc and MSVC even throws an error (see #85 )

Probably should be tested before we merge (I might do the testing later on)

This fixes #85

erikzenker commented 9 years ago

Do you think it would be better to replace these line by using ... ?

slizzered commented 9 years ago

Both variants are equivalent for gcc, don't know about MSVC. For now, I considered the typedef for more "classic" and therefore more compatible. But you are right, the using syntax is a lot nicer. I will try both when testing on Windows

erikzenker commented 9 years ago

I think if you rebase with current dev, we can merge this.

erikzenker commented 9 years ago

Now I call you the master of rebase !!! :imp: