search

ComputationalRadiationPhysics / isaac

In Situ Animation of Accelerated Computations :microscope:
http://ComputationalRadiationPhysics.github.io/isaac/
GNU Lesser General Public License v3.0
25 stars 15 forks source link

AO bug via pre-compiler flag broken #119

Closed psychocoderHPC closed 4 years ago

psychocoderHPC commented 4 years ago

The newly introduced CMake flag ISAAC_AO_BUG_FIX introduced in #112 is not given to the compiler and therefore ambient occlusion is still broken.

see: https://github.com/ComputationalRadiationPhysics/isaac/pull/112/files#r518781765

The define must be added via cmake target compile definitions.

psychocoderHPC commented 4 years ago

dublicate of #120 (cmake was showing an error but was creating the issue)