Simplification of the code by using glm and reducing templates

ComputationalRadiationPhysics / isaac

In Situ Animation of Accelerated Computations :microscope:

GNU Lesser General Public License v3.0

25 stars 15 forks source link

Closed FelixTUD closed 3 years ago

FelixTUD commented 3 years ago

BREAKING CHANGES TO THE ISAAC INTERFACE

Removed templates for IsaacVisualization class changes expected types to be isaac internal types like isaac_float3
isaac now expects the render volume to be 3D, the 2D implementation wasn't working before anyway
Guaranteed internal types simplify the code structure
Removal of unnecessary templates, as they already had many requirements at the type, which often resulted in complicated compiler errors if they were not met

psychocoderHPC commented 3 years ago

Is it possible to use the upstream version of glm for issac. If I remember correctly some changes were required to support CUDA.

psychocoderHPC commented 3 years ago

Please add glm to the requirements in INSTALL.md. If a minimal version is required add this information too.

FelixTUD commented 3 years ago

Yes for CUDA a recent glm upstream version works without adjustments, only the future hip support needs some changes

FelixTUD commented 3 years ago

@psychocoderHPC the requested changes are integrated