ComputationalRadiationPhysics / isaac

In Situ Animation of Accelerated Computations :microscope:

http://ComputationalRadiationPhysics.github.io/isaac/

GNU Lesser General Public License v3.0

25 stars 15 forks source link

Invalid Functor Pipeline Crashes Library #85

Closed PrometheusPi closed 5 years ago

PrometheusPi commented 5 years ago

~~Using the length functor on particles (and probably some other functors as well) leads to a crash of PIConGPU.~~ A not correct pipeline according to the ally synatx (missing pipe | or similar) causes a crash of the parser in PIConGPU.

This should be avoided by sending back a warning and not visualizing the quantity.

ax3l commented 5 years ago

@FelixTUD this is probably your expertise, can you help? :)

@PrometheusPi please provide an exact reproducer a la "using the LWFA example with PIConGPU vX.Y.Z and writing the functor chain length | mul(2.3) on electrons leads to a crash with the following output: ..."

PrometheusPi commented 5 years ago

@FelixTUD wrote by mail: particles are by default vectors of memntum for the visualizer wich only take the x component. If the functor length is applied - the length of the momentum is taken.

length | mul(2)

However, missing the pipe | or adding parenthesis to length causes a crash in the parser.

FelixTUD commented 5 years ago

Will be fixed with the particle integration in pull request #88

FelixTUD commented 5 years ago

88 is merged and issue is resolved, can be closed