Refactor Code - Githubissues

ComputationalRadiationPhysics / jungfrau-photoncounter

Conversion of Jungfrau pixel detector data to photon count rate

GNU General Public License v3.0

2 stars 2 forks source link

Refactor Code #69

Open kloppstock opened 3 years ago

kloppstock commented 3 years ago

There are a lot of things in the code that are currently not really needed, that might hurt performance slightly or that might cause confusion.

Not really needed:

[ ] Remove the RingBuffer
[ ] Remove READY, PROCESSING, FREE

Performance:

[ ] Rename the frameNumber inside the Cluster struct to something more descriptive (e.g. frameId)
[ ] Use uint32_t instead of uin64_t in kernel loops
[ ] Use double loops in kernels to speed up kernel execution
[ ] Fine tune element layer size

Confusing:

[ ] Refactor the the calibration code to work in a similar fashion the main processing code
[ ] Unify usage of numMaps and numFrames
[ ] Unify naming conventions of filenames
[ ] Refactor return value of the enqueueKernel function