search

ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

Writing Actual Global Attributes #173

Closed ax3l closed 9 years ago

ax3l commented 9 years ago

Refactoring: Currently, when using writeGlobalAttribute calls, the SDC_GROUP_CUSTOM is used.

Nevertheless, we need a bit more control over that or could even consider replacing the /custom/ group with the actual global root /.

Background: Needed to allow writing valid openPMD files (which requires some attributes in /).

ax3l commented 9 years ago

@psychocoderHPC @f-schmitt-zih am I missing something or is writing an attribute to / currently not possible? :)

ax3l commented 9 years ago

If that is the case, I would vote for removing the group /custom and using / directly instead with the current file format change to 3.x.

Was there a special reason to introduce the extra group?

ax3l commented 9 years ago

ah, I see... the SerialDataCollector has a non-merging-mode where the global attributes are allowed to differ between different MPI ranks...

well for that specific case we could write it still in a custom group, for serial+merging and parallel that does not matter.

ax3l commented 9 years ago

@psychocoderHPC @f-schmitt-zih pls provide me some feedback on that issue :)

ax3l commented 9 years ago

Closed with #182